Update polling and timeout message handling | CTT-188#335
Merged
Conversation
… handling of polls
This change allows a proper detection of NO DDA flows in verification mode even when websockets are insanely fast in their detection
mwclemy
reviewed
Jun 2, 2026
mwclemy
reviewed
Jun 2, 2026
mwclemy
reviewed
Jun 2, 2026
wesrisenmay-mx
previously approved these changes
Jun 3, 2026
This reverts commit e3b16a8.
wesrisenmay-mx
approved these changes
Jun 8, 2026
|
🎉 This PR is included in version 2.24.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements some edge-case fixes that have been reported by customers, which cause the user to get stuck on the Connecting screen, or get the wrong screen.
Side Note - While testing the above, it was also discovered that sometimes the widget would show a false-positive success screen in No DDA scenarios. The fix for this is being investigated as a backend change.
Fixes
Test Results
✅ Vitest
✅ New Playwright OAuth tests
✅ Cypress Tests (when npm linked to these changes)