Skip to content

Update polling and timeout message handling | CTT-188#335

Merged
codingLogan merged 6 commits into
masterfrom
lr/CTT-188
Jun 8, 2026
Merged

Update polling and timeout message handling | CTT-188#335
codingLogan merged 6 commits into
masterfrom
lr/CTT-188

Conversation

@codingLogan

@codingLogan codingLogan commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

This PR implements some edge-case fixes that have been reported by customers, which cause the user to get stuck on the Connecting screen, or get the wrong screen.

  1. Sometimes the first response from the backend APIs already signal that the job is done, and in an error state. The widget incorrectly would keep on polling waiting for a different response from the first one. This was recreated by using a Slow 3G network speed emulation, and using verification and No DDA member.
  2. Not aggregating fix - we have a handler for when we don't have an explicit actionable error code, but we are in a connection_status that is an error. Updates were made to allow that state to be reached.
  3. The two above fixes also exposed another problem. The Connecting screen is supposed to send a timeout post message after 60 seconds. Polling timing has changed in the last half-year, and this the timeout message was out of sync. This problem has also been addressed because the above two fixes changed that code as well.

Side Note - While testing the above, it was also discovered that sometimes the widget would show a false-positive success screen in No DDA scenarios. The fix for this is being investigated as a backend change.

Fixes

  • 188
  • 190
  • 191

Test Results

✅ Vitest
✅ New Playwright OAuth tests
✅ Cypress Tests (when npm linked to these changes)

@codingLogan codingLogan marked this pull request as ready for review June 2, 2026 16:03
@codingLogan codingLogan self-assigned this Jun 2, 2026
Comment thread src/hooks/usePollMember.tsx Outdated
Comment thread src/hooks/__tests__/usePollMember-test.tsx Outdated
Comment thread src/views/connecting/Connecting.js
Comment thread src/utilities/__tests__/pollers-test.js Outdated
Comment thread src/utilities/__tests__/pollers-test.js Outdated
Comment thread README.md Outdated
wesrisenmay-mx
wesrisenmay-mx previously approved these changes Jun 3, 2026
@codingLogan codingLogan merged commit 8a4e773 into master Jun 8, 2026
6 checks passed
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

🎉 This PR is included in version 2.24.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants